fix: complete Playwright removal in CI deploy workflow
Drop the leftover Playwright browser install and e2e smoke test from the deployment script, and update the deployment contract tests to cover the verify-deployed-release smoke check instead.
This commit is contained in:
@@ -77,7 +77,7 @@ describe("deployment transaction", () => {
|
||||
expect(result.calls.indexOf("pnpm db:migrate")).toBeLessThan(
|
||||
result.calls.indexOf("docker stop"),
|
||||
);
|
||||
expect(result.calls.indexOf("pnpm test:e2e")).toBeLessThan(
|
||||
expect(result.calls.indexOf("verify-deployed-release.mjs")).toBeLessThan(
|
||||
result.calls.indexOf(
|
||||
`docker tag epicnext-cms:${sha} epicnext-cms:latest`,
|
||||
),
|
||||
|
||||
@@ -61,7 +61,8 @@ describe("CI workflow", () => {
|
||||
it("smoke-tests the deployed app within the deployment transaction", () => {
|
||||
expect(workflow).toContain("bash scripts/ci-deploy.sh");
|
||||
const deploy = readFileSync("scripts/ci-deploy.sh", "utf8");
|
||||
expect(deploy).toContain("pnpm test:e2e");
|
||||
expect(deploy).toContain("PLAYWRIGHT_BASE_URL");
|
||||
expect(deploy).toContain(
|
||||
"node scripts/verify-deployed-release.mjs http://127.0.0.1:3002/api/health",
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -8,7 +8,7 @@ it("uses two test workers and runs smoke checks in the deployment transaction",
|
||||
expect(workflow).not.toContain("\n e2e:");
|
||||
expect(workflow).toContain("bash scripts/ci-deploy.sh");
|
||||
expect(deploy).toContain(
|
||||
"PLAYWRIGHT_BASE_URL=http://127.0.0.1:3002 pnpm test:e2e",
|
||||
"node scripts/verify-deployed-release.mjs http://127.0.0.1:3002/api/health",
|
||||
);
|
||||
});
|
||||
it("locks CI and scheduled deployments using the same production lock", () => {
|
||||
|
||||
@@ -13,7 +13,6 @@ flock() { echo "lock" >> "$TEST_DIR/calls"; [ "$SCENARIO" != lock-failure ]; }
|
||||
pnpm() {
|
||||
echo "pnpm $*" >> "$TEST_DIR/calls"
|
||||
if [ "$1" = db:migrate ] && [ "$SCENARIO" = migration-failure ]; then return 1; fi
|
||||
if [ "$1" = test:e2e ] && [ "$SCENARIO" = smoke-failure ]; then return 1; fi
|
||||
return 0
|
||||
}
|
||||
curl() {
|
||||
@@ -43,5 +42,12 @@ docker() {
|
||||
}
|
||||
export -f git flock pnpm curl sleep docker
|
||||
|
||||
node() { echo "node $*" >> "$TEST_DIR/calls"; [ "$SCENARIO" != release-failure ]; }
|
||||
node() {
|
||||
echo "node $*" >> "$TEST_DIR/calls"
|
||||
case "$SCENARIO" in
|
||||
release-failure) return 1 ;;
|
||||
smoke-failure) case "$*" in *verify-deployed-release.mjs*) return 1 ;; esac ;;
|
||||
esac
|
||||
return 0
|
||||
}
|
||||
export -f node
|
||||
|
||||
Reference in New Issue
Block a user