openhands
6cc45d7413
Second review pass covering security, performance, admin tooling and the public/room flows. All HIGH and MEDIUM findings from the audit are resolved; nothing in this commit changes the visible feature set. Authentication & session security - CSP is now set on the request headers in the proxy, which is what Next.js uses to derive the render nonce, so the nonce is effective. - 2FA: an already-enabled user cannot re-enroll, the setup endpoint is rate-limited per account, and confirmed codes are persisted so the second secret no longer silently never applies. - Password reset revokes the ticket, authTicket and all personal access tokens, and bumps the token version so existing sessions die. The same revocation is now wired into the staff-side password reset. - /reset and /verify return a stable error code instead of raw text; the mail lookups are ordered by id so duplicates cannot vary between runs. - Resending the verification mail gets a per-address cooldown on top of the per-user limit. - Issue API tokens with the narrower radio/ticket ability set instead of "*". Authorization & input handling - Mid-rank staff can no longer keep dynamically granted non-view admin.* permissions: existing grants are revoked by migration and the grant lookup is restricted to "%.view". Rank guards use the dynamic super-admin check. - Alerting a user is permission-checked and audited like the other tools. - Material mutations (giveCredits/giveDuckets/giveDiamonds, the admin user actions route, bulk user actions) are capped and rank-guarded, and bulk ids are bounded. - updateRoom / updateRoomItem write through a field allowlist, and items may only be edited through their own room. - Classnames reaching the filesystem are validated before use so a crafted value cannot escape the asset directories. - The word filter now also covers offline mails, guild forum threads and replies, and user mottos. - Media uploads are validated by magic bytes, /api/media requires the page edit permission, APP_URL must be configured once mail is enabled, and the diagnostics error route checks the fetch site header. Admin tooling - Secret settings render masked and cannot be overwritten with a blank or an arbitrary raw key; radio credentials are new password inputs. - Commandocentrum balance changes are audited. - Admin list pagination reads the caller's per-page instead of the max, and the log exporter caps offset and search length. Performance - Catalog translations are cached per module, with a cheap revision hash; the public online count uses a stale window instead of hammering the DB. - The cache warmup now primes the payload the home route actually reads. - TopHeader batches its queries into one round trip, and LCP avatars load eagerly. - motion/react and sonner are no longer part of the root layout; the nav dropdown and mobile nav panels are lazy client chunks. Anonymous visitors again get the navigation chrome, and public pages get an edge cacheable response. Accessibility - Nested <main> elements in phase pages became <section>; the page entrance and route progress animations are pure CSS that respect reduced motion.
83 lines
2.5 KiB
TypeScript
83 lines
2.5 KiB
TypeScript
import { asc } from "drizzle-orm";
|
|
import { Settings } from "lucide-react";
|
|
import { redirect } from "next/navigation";
|
|
import { getTranslations } from "next-intl/server";
|
|
import { AdminPageShell } from "@/components/admin/admin-page-shell";
|
|
import { db, WebsiteSetting } from "@/lib/db";
|
|
import { canAccess, getAdminContext, PERMS } from "@/lib/permissions";
|
|
import {
|
|
isSecretSettingKey,
|
|
SECRET_PLACEHOLDER,
|
|
} from "@/lib/services/setting-secrets";
|
|
import { AdvancedSettingsPanel } from "./advanced-settings-panel";
|
|
import { FIELD_DEFAULTS, MANAGED_SETTING_KEYS } from "./cms-settings-config";
|
|
import { CmsSettingsForm } from "./cms-settings-form";
|
|
|
|
export const metadata = { title: "CMS Settings" };
|
|
|
|
export default async function AdminSettings() {
|
|
const { session, permissions } = await getAdminContext();
|
|
if (!canAccess(permissions, PERMS.SETTINGS_VIEW, session.user.rank)) {
|
|
redirect("/admin");
|
|
}
|
|
const canEdit = canAccess(
|
|
permissions,
|
|
PERMS.SETTINGS_EDIT,
|
|
session.user.rank,
|
|
);
|
|
const t = await getTranslations("pages.admin.settings");
|
|
|
|
let settings: (typeof WebsiteSetting.$inferSelect)[] = [];
|
|
try {
|
|
settings = await db
|
|
.select()
|
|
.from(WebsiteSetting)
|
|
.orderBy(asc(WebsiteSetting.key));
|
|
} catch {
|
|
settings = [];
|
|
}
|
|
|
|
const dbValues = new Map(settings.map((s) => [s.key, s.value]));
|
|
const values: Record<string, string> = Object.fromEntries(
|
|
MANAGED_SETTING_KEYS.map((key) => [
|
|
key,
|
|
dbValues.get(key) ?? FIELD_DEFAULTS[key] ?? "",
|
|
]),
|
|
);
|
|
|
|
const documented = settings.filter((s) => !!s.comment).length;
|
|
|
|
return (
|
|
<AdminPageShell icon={Settings} title={t("title")} subtitle={t("subtitle")}>
|
|
<div className="space-y-8">
|
|
<div className="admin-stat-row">
|
|
<span className="admin-stat-chip">
|
|
{t("keysInDatabase", { count: settings.length })}
|
|
</span>
|
|
<span className="admin-stat-chip">
|
|
{t("managedInForm", { count: MANAGED_SETTING_KEYS.length })}
|
|
</span>
|
|
<span className="admin-stat-chip">
|
|
{t("documented", { count: documented })}
|
|
</span>
|
|
</div>
|
|
|
|
<CmsSettingsForm values={values} canEdit={canEdit} />
|
|
|
|
<AdvancedSettingsPanel
|
|
// Credentials never leave the server: a reader with only
|
|
// SETTINGS_VIEW must not receive captcha/radio secrets in the
|
|
// payload, and an editor sees a "keep stored value" placeholder.
|
|
settings={settings.map((s) => ({
|
|
key: s.key,
|
|
value: isSecretSettingKey(s.key) ? SECRET_PLACEHOLDER : s.value,
|
|
comment: s.comment,
|
|
secret: isSecretSettingKey(s.key),
|
|
}))}
|
|
canEdit={canEdit}
|
|
/>
|
|
</div>
|
|
</AdminPageShell>
|
|
);
|
|
}
|